iPhone X camera glass replacement with water seal?

it will unless you get the proper foam adhesive used to reseal it, and apply the lens in a dust free environment, without getting your fingers on the adhesive. Essentially, good technicians are trained to do this, and will have access to the proper parts for the repair. If you absolutely want the ip68 classification to stay in tact, then you will need the above repair done.

HOWEVER! getting the device repaired outside of manufacturer facilities will remove the ip68 CERT. This certification is ONLY from the manufacturer, and not given by anyone else.